-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: WEOS-1382 As a developer I should be able to set the type of id that I want auto generated #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added spec for generating ksuid by default * Added spec for generating UUID * Added spec for generating integer id
* Removed integer id generation from WEOS-1382
-Generated bdd test
… id that I want auto generated -Added GenerateID function to the content entity file -Fix all create content type test in the receiver -Added a test in the content type for generateid -Updated fixture for the test
… id that I want auto generated -Fleshed out bdd functions
… id that I want auto generated -Ensure bdd test passing
…ed for auto increment
… id that I want auto generated -Updating the functionality in Generatedid -Updated create schema to check for the format of the integer property and if its uint add it as that -Updated test functionality -Add Generateid to return domain errors
… id that I want auto generated -Added some log lines to errors
… id that I want auto generated -Updated bdd test -Updated feature file
… id that I want auto generated -Add back tag
feature: WEOS-1382 As a developer I should be able to set the type of id that I want auto generated
# Conflicts: # end2end_test.go
feature: WEOS-1382 As a developer I should be able to set the type of id that I want auto generated
Aidan-E
previously approved these changes
Mar 10, 2022
akeemphilbert
requested changes
Mar 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I removed "And" from one of the steps so that is uses the same "the specification is" as the other features, the tests failed
… id that I want auto generated -Updated fixture -Updated bdd test
# Conflicts: # end2end_test.go
… id that I want auto generated -Updated fixture -Updated bdd test
* Added Init method to be used when adding a new entity to the system * Added a Create method on the entity factory for adding a new entity to the system * Added a constant for the create event * Updated create receiver so that the generate id happens in the entity and the event is added in the entity * Added code to receiver to add a WEOS ID to context IF one is specified on the create command (this was an attempt to maintain compability with existing code)
feature: WEOS-1382 Auto generate id
… id that I want auto generated -Fix functionality for create batch to work -Added extra check to see if the id generated was valid format -Debugging bdd test -Added weosid to map payload in gorm -Added some extra checks for integer in the generate -Added entityid to the context for the createbatch domain service function -Ensure all test is passing
… id that I want auto generated -Added a default to the switch if the format specified is not supported -Checks if the error returned from the create entity values is a domain error if not makes one
… id that I want auto generated -Debug test
# Conflicts: # end2end_test.go
akeemphilbert
approved these changes
Mar 14, 2022
Aidan-E
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Now you can auto generate your x-identifier once only one is specified based on its format
-If the format is not specified and error is thrown
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: