Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: WEOS-1382 As a developer I should be able to set the type of id that I want auto generated #140

Merged
merged 32 commits into from
Mar 16, 2022

Conversation

shaniah868
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

-Now you can auto generate your x-identifier once only one is specified based on its format
-If the format is not specified and error is thrown

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

akeemphilbert and others added 20 commits March 4, 2022 07:18
* Added spec for generating ksuid by default
* Added spec for generating UUID
* Added spec for generating integer id
* Removed integer id generation from WEOS-1382
… id that I want auto generated

-Added GenerateID function to the content entity file
-Fix all create content type test in the receiver
-Added a test in the content type for generateid
-Updated fixture for the test
… id that I want auto generated

-Fleshed out bdd functions
… id that I want auto generated

-Ensure bdd test passing
… id that I want auto generated

-Updating the functionality in Generatedid
-Updated create schema to check for the format of the integer property and if its uint add it as that
-Updated test functionality
-Add Generateid to return domain errors
… id that I want auto generated

-Added some log lines to errors
… id that I want auto generated

-Updated bdd test
-Updated feature file
… id that I want auto generated

-Add back tag
feature: WEOS-1382 As a developer I should be able to set the type of id that I want auto generated
# Conflicts:
#	end2end_test.go
feature: WEOS-1382 As a developer I should be able to set the type of id that I want auto generated
Aidan-E
Aidan-E previously approved these changes Mar 10, 2022
Copy link
Contributor

@akeemphilbert akeemphilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I removed "And" from one of the steps so that is uses the same "the specification is" as the other features, the tests failed

model/content_entity.go Outdated Show resolved Hide resolved
model/content_entity.go Outdated Show resolved Hide resolved
model/content_entity.go Outdated Show resolved Hide resolved
model/receiver.go Outdated Show resolved Hide resolved
shaniah868 and others added 4 commits March 11, 2022 11:12
… id that I want auto generated

-Updated fixture
-Updated bdd test
# Conflicts:
#	end2end_test.go
… id that I want auto generated

-Updated fixture
-Updated bdd test
* Added Init method to be used when adding a new entity to the system
* Added a Create method on the entity factory for adding a new entity to the system
* Added a constant for the create event
* Updated create receiver so that the generate id happens in the entity and the event is added in the entity
* Added code to receiver to add a WEOS ID to context IF one is specified on the create command (this was an attempt to maintain compability with existing code)
akeemphilbert and others added 6 commits March 11, 2022 15:31
feature: WEOS-1382 Auto generate id
… id that I want auto generated

-Fix functionality for create batch to work
-Added extra check to see if the id generated was valid format
-Debugging bdd test
-Added weosid to map payload in gorm
-Added some extra checks for integer in the generate
-Added entityid to the context for the createbatch domain service function
-Ensure all test is passing
… id that I want auto generated

-Added a default to the switch if the format specified is not supported
-Checks if the error returned from the create entity values is a domain error if not makes one
# Conflicts:
#	end2end_test.go
@akeemphilbert akeemphilbert merged commit 9f1fe15 into dev Mar 16, 2022
@akeemphilbert akeemphilbert deleted the feature/WEOS-1382 branch March 16, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants